devd: remove #165592
devd: remove #165592
Conversation
Signed-off-by: Rui Chen <[email protected]>
github-actions
bot
added
go
| # We backported upstream support for Go modules, but have not received | ||
| # a response on request for a new release since 2021-01-21. | ||
| # Issue ref: https://github.com/cortesi/devd/issues/115 | ||
| disable! date: "2023-10-03", because: :unmaintained |
There was a problem hiding this comment.
This is why it had zero installs in the last 90 days. Should we wait until 2024-10-03 before removing this?
https://docs.brew.sh/Deprecating-Disabling-and-Removing-Formulae#removal
There was a problem hiding this comment.
we talked about in the AGM that we dont have to wait for the full year.
There was a problem hiding this comment.
We don't, but there isn't really any reason not to, since they're automatically removed already.
I suggest updating the automated removal workflow if you'd rather disabled formulae were deleted sooner.
There was a problem hiding this comment.
yeah, I can also make some change for the deletion automation
There was a problem hiding this comment.
I'm trying to improve the deprecation docs: Homebrew/brew#16829
they can be manually removed three months after their disable date.
We should change this to: "automatically disabled", so we don't have to run manual actions. Let the bot do the hard work for us.
There was a problem hiding this comment.
We should change this to: "automatically disabled"
You mean "automatically removed", right? Which also means the one-year automatic removal mentioned in the "Removal" section would take place sooner.
chenrui333
added
the
CI-syntax-only
There was a problem hiding this comment.
I'm fine with this PR then, given:
They can be manually removed three months after their disable date.
... which I didn't notice before.
| # We backported upstream support for Go modules, but have not received | ||
| # a response on request for a new release since 2021-01-21. | ||
| # Issue ref: https://github.com/cortesi/devd/issues/115 | ||
| disable! date: "2023-10-03", because: :unmaintained |
There was a problem hiding this comment.
We should change this to: "automatically disabled"
You mean "automatically removed", right? Which also means the one-year automatic removal mentioned in the "Removal" section would take place sooner.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?