Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widelands 1.1 #143984

Closed
Closed

Conversation

jonhermansen
Copy link
Contributor

Created with brew bump-formula-pr.

@github-actions github-actions bot added lua Lua use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` boost Boost use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue labels Sep 19, 2023
@chenrui333
Copy link
Member

chenrui333 commented Sep 19, 2023

 patch -g 0 -f -p1 -i /private/tmp/widelands--patch-20230919-20171-xfum5l/316eaea209754368a57f445ea4dd016ecf8eded6.patch
  patching file src/network/bufferedconnection.h
  Hunk #1 FAILED at 20.
  1 out of 1 hunk FAILED -- saving rejects to file src/network/bufferedconnection.h.rej

@chenrui333
Copy link
Member

see previous efforts in here, #113841

@chenrui333 chenrui333 added the build failure CI fails while building the software label Sep 19, 2023
@jonhermansen
Copy link
Contributor Author

see previous efforts in here, #113841

Thanks, I can see you are have many brew livecheck changes covered.

In your opinion, what is best way to help contribute here?

Maybe I would like to add additional livechecks, especially for the most critical-path libraries and popular packages. Is it a good idea? Are the Homebrew analaytics for package popularity available for the public? Thanks @chenrui333

@chenrui333
Copy link
Member

In your opinion, what is best way to help contribute here?

See https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md ?

We have lots issues also captured in here, #139929

And you can also check help-wanted label.

Let me know if that answers your question.

@chenrui333
Copy link
Member

closing, feel free to make a new once you get all checks passed in your local.

@chenrui333 chenrui333 closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boost Boost use is a significant feature of the PR or issue build failure CI fails while building the software bump-formula-pr PR was created using `brew bump-formula-pr` icu4c ICU use is a significant feature of the PR or issue lua Lua use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants