Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libplist 2.3.0 #142057

Merged
merged 16 commits into from Sep 17, 2023
Merged

libplist 2.3.0 #142057

merged 16 commits into from Sep 17, 2023

Conversation

TheRealKeto
Copy link
Contributor

@TheRealKeto TheRealKeto commented Sep 12, 2023 •
edited

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Looking through all previous pull requests, I've managed to solve all issues relating to libplist and its newest verison. libirecovery is not handled here, as I believe it should be handled in a new pull request (which was actually resolved by a closed PR, can it be reopened?).

Should it be handled here instead, please let me know.

@TheRealKeto TheRealKeto force-pushed the update/libplist branch 2 times, most recently from 5594db7 to 1dfd9f0 Compare September 12, 2023 05:14
@chenrui333
Copy link
Member 

brew linkage --test ideviceinstaller
brew test --retry --verbose ideviceinstaller

@chenrui333 chenrui333 added build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Sep 12, 2023
@TheRealKeto
Copy link
Contributor Author

@chenrui333 Updated missed packages. Some CI jobs were skipped, not sure why.

@TheRealKeto
Copy link
Contributor Author

@p-linnane Mind reviewing this?

p-linnane
p-linnane reviewed Sep 17, 2023
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any references to --disable-dependency-tracking or --prefix=#{prefix} should be removed and replaced with *std_configure_args.

Additionally, don't we still want to run ./configure even when building from HEAD?

@TheRealKeto
Copy link
Contributor Author

TheRealKeto commented Sep 17, 2023 •
edited

Additionally, don't we still want to run ./configure even when building from HEAD?

./autogen.sh automatically runs ./configure once it generates all files. This line example proves it.

@p-linnane
Copy link
Member

--disable-silent-rules is not part of *std_configure_args, so that will need to be added back where necessary. Once that and the style issue are addresses this should be good to merge.

p-linnane
p-linnane approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the great work here!

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 17, 2023
@TheRealKeto
Copy link
Contributor Author

The bot seemed to have ran into issues. Should I resolve the merge conflicts manually?

@chenrui333 chenrui333 added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. and removed build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Sep 17, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 17, 2023
@chenrui333
Copy link
Member

@TheRealKeto, thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

@chenrui333
Copy link
Member

#139929

@chenrui333 chenrui333 removed the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Sep 17, 2023
Merged via the queue into Homebrew:master with commit 0af29cd Sep 17, 2023
19 checks passed
@TheRealKeto TheRealKeto deleted the update/libplist branch September 17, 2023 23:57
@TheRealKeto TheRealKeto mentioned this pull request Sep 18, 2023
Merged
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TheRealKeto @chenrui333 @p-linnane @BrewTestBot