Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simpletex: update livecheck #174091

Merged
merged 1 commit into from
May 17, 2024
Merged

simpletex: update livecheck #174091

merged 1 commit into from
May 17, 2024

Conversation

samford
Copy link
Member

@samford samford commented May 17, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

This is a follow-up to #173943, updating the livecheck block to use the Json strategy (I was too slow to review that PR). The regex approach requires the macos_version and macos_latest_version values to be adjacent but the Json approach will work regardless of the order.

@samford samford added the livecheck Issues or PRs related to livecheck label May 17, 2024
This is a follow-up to #173943, updating the `livecheck` block to
use the `Json` strategy. The regex approach requires the
`macos_version` and `macos_latest_version` values to be adjacent but
the `Json` approach will work regardless of the order.
@samford samford force-pushed the simpletex-update-livecheck branch from 4874ed9 to 1e32243 Compare May 17, 2024 01:10
@miccal miccal merged commit 9463ae9 into master May 17, 2024
9 checks passed
@miccal miccal deleted the simpletex-update-livecheck branch May 17, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants