Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

j 9.5.2 #171865

Merged
merged 2 commits into from May 5, 2024
Merged

j 9.5.2 #171865

merged 2 commits into from May 5, 2024

Conversation

secwang
Copy link
Contributor

@secwang secwang commented Apr 21, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

@BrewTestBot BrewTestBot added the missing zap Cask is missing a zap stanza, please add one. label Apr 21, 2024
@bevanjkay
Copy link
Member

Is there any confirmation available from upstream as to why the checksum has changed? It can indicate that the binary has been compromised.

@secwang
Copy link
Contributor Author

secwang commented Apr 22, 2024

Is there any confirmation available from upstream as to why the checksum has changed? It can indicate that the binary has been compromised.

They update binary file in this position at 3.25 ,After that, all brew install j is wrong..
https://www.jsoftware.com/download/j9.5/install/
I think they made a small version upgrade, but it's still 9.5.
New checksum can be found at https://www.jsoftware.com/download/j9.5/install/sha256sums

@miccal
Copy link
Member

miccal commented May 5, 2024

@samford the latest version here is actually 9.5.2 and the file is located at https://www.jsoftware.com/download/j9.5/install/j9.5.2_mac64.zip.

The not-beta release 9.5 is shown on the current livecheck url at https://code.jsoftware.com/wiki/System/Installation.

This page https://www.jsoftware.com/download/j9.5/install/ states The current version is J9.5.2., while this page https://www.jsoftware.com/download/j9.6/install/ states The current version is J9.6.0-beta5..

Can you think of a way such that livecheck can check https://www.jsoftware.com/download/j#{version.major_minor}/install/ for the current non-beta version and then produce https://www.jsoftware.com/download/j#{version.major_minor}/install/j#{version}_mac64.zip?

I have not had any luck so far.

Thanks!

@miccal miccal requested a review from samford May 5, 2024 03:39
@samford
Copy link
Member

samford commented May 5, 2024

Can you think of a way such that livecheck can check https://www.jsoftware.com/download/j#{version.major_minor}/install/ for the current non-beta version and then produce https://www.jsoftware.com/download/j#{version.major_minor}/install/j#{version}_mac64.zip?

Looking at the available sources (thanks for the links), this appears to be one of those situations where we have to check two pages. In this case, we have to fetch the release version from the Installation page (e.g., 9.5) and then use that to generate the versioned download page URL (https://www.jsoftware.com/download/j9.5/install/) to fetch that, as you suggested. [To be clear, we can't identify release versions from the version directory names on https://www.jsoftware.com/download because there's no way to distinguish between stable versions (e.g., 9.5) and unstable versions (e.g., 9.6), as they both use a stable version format.]

I'll push a commit in a moment to rework the livecheck block and update this to 9.5.2 (edit: done).

@samford
Copy link
Member

samford commented May 5, 2024

@secwang When creating PRs in the future, please create a new branch on your fork (e.g., j-update-checksum) instead of making the commit(s) on the master branch. That makes it a little easier for maintainers to check out your PR branch and make commits to it (if necessary).

@secwang
Copy link
Contributor Author

secwang commented May 5, 2024

@secwang When creating PRs in the future, please create a new branch on your fork (e.g., j-update-checksum) instead of making the commit(s) on the master branch. That makes it a little easier for maintainers to check out your PR branch and make commits to it (if necessary).

Okay

The `livecheck` block checks the upstream Installation wiki page but
this only lists major/minor release versions. To identify subsequent
patch versions (e.g., 9.5.2), we have to check the download page for
a given release, which links to dmg files like `j9.5.2_mac64.zip`.
@samford samford changed the title Update checksum for j j 9.5.2 May 5, 2024
@miccal
Copy link
Member

miccal commented May 5, 2024

Thank you very much @samford.

@miccal miccal merged commit 6cbc970 into Homebrew:master May 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing zap Cask is missing a zap stanza, please add one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants