Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simpletex 0.2.6 (new cask) #171841

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

singularitti
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@razvanazamfirei razvanazamfirei changed the title Add cask simpletex v0.2.6 simpletex 0.2.6 (new cask) Apr 20, 2024
version :latest
sha256 :no_check

url "https://simpletex.cn/download_mac_#{arch}_url"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link redirects to: https://gitee.com/simpletex/simple-tex-download/releases/download/v0.2.5/SimpleTex-0.2.6-arm64.dmg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware of this. However, I think they have messed up the release numbers, since v0.2.6 is released under a v0.2.5 tag.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the issue to be resolved then.
We should use the versioned url wherever possible as it provides the additional security of having checksum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll contact them to fix this.

name "simpletex"
desc "Formula snipping and recognition app"
homepage "https://simpletex.cn/"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it uses Electron, can we use https://update.simpletex.cn/publish/electron/latest-mac.yml for the livecheck?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I did not add this link since I cannot have access to this link. Could you please verify that this link is valid?

Casks/s/simpletex.rb Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants