Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepl: downgrade to 24.1.1725245 #170781

Conversation

daeho-ro
Copy link
Contributor

@daeho-ro daeho-ro commented Apr 6, 2024

Checked the livecheck url and noticed that the version is retracted but don't know why.


Reverts #166774

@daeho-ro daeho-ro force-pushed the revert-166774-bump-deepl-24.1.2756848 branch from 6ca19c9 to f431d40 Compare April 6, 2024 06:42
@daeho-ro daeho-ro force-pushed the revert-166774-bump-deepl-24.1.2756848 branch from f431d40 to 168f13b Compare April 6, 2024 06:43
@daeho-ro daeho-ro changed the title Revert "deepl 24.1.2756848" deepl: downgrade to 24.1.1725245 Apr 6, 2024
@daeho-ro daeho-ro force-pushed the revert-166774-bump-deepl-24.1.2756848 branch from 168f13b to d75f037 Compare April 6, 2024 06:44
@razvanazamfirei
Copy link
Member

Weirdly, their website is actually serving 24.2.1798840 1798840 so the livecheck is out of date.

@krehel
Copy link
Member

krehel commented Apr 8, 2024

I'm wondering if we should unversion this or resort to :extract_plist as an absolute last resort since the download file is almost 100mb, with the app being about 200mb.

It would be not ideal, but looking back through 2023 PRs there's been an issue with updates several times.

@krehel krehel marked this pull request as draft April 8, 2024 15:23
@krehel
Copy link
Member

krehel commented Apr 8, 2024

Converting to draft so this isn't approved and merged.

@daeho-ro
Copy link
Contributor Author

daeho-ro commented Apr 9, 2024

I think closing is good, just wait for the next version and we could check it later again.

@daeho-ro daeho-ro closed this Apr 9, 2024
@MoienBowen
Copy link
Contributor

@daeho-ro
Hi, please excuse to reopen the issue again.
DeepL has been updated to 24.4.1889124, however, the script does not work appropriately.

The livecheck always gives the 24.1 version, but the app keeps promoting a notification for updating.

https://www.deepl.com/en/macos-app/

@daeho-ro daeho-ro reopened this Apr 22, 2024
@daeho-ro daeho-ro marked this pull request as ready for review April 22, 2024 08:38
@miccal
Copy link
Member

miccal commented Apr 25, 2024

@samford any chance you can work your magic using https://appdownload.deepl.com/macos/?

The current version this page points to is 24.4.2902956.

Thanks.

@samford
Copy link
Member

samford commented Apr 25, 2024

any chance you can work your magic using https://appdownload.deepl.com/macos/?

The current version this page points to is 24.4.2902956.

Thanks for pointing me to the URL. I was able to put together a new livecheck block using the Xml strategy and it returns 24.4.2912025 as the latest version now. Since we also need to update the cask to 24.4.2912025, I'll just create a new PR for the version bump and livecheck block changes (#172196).

@samford samford mentioned this pull request Apr 25, 2024
9 tasks
@miccal
Copy link
Member

miccal commented Apr 25, 2024

Closing in favour of #172196.

@miccal miccal closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants