enforce limit of one subcommand, list named_args #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding named_args will let Homebrew::Completions discover subcommands - limiting subcommmands stops user from adding arguments we won't execute anyway - can't use `max: 1` because this would break `brew bundle exec`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
named_argsso Homebrew::Completions can discover subcommandsraisean error ifargs.named.size > 1, unless we're runningbrew bundle exec: this fails loudly on some commands that are currently accepted and may appear valid but don't do what you'd expect. Each of the below commands currently execute the first subcommand and ignore the second silently:brew bundle install my_packagebrew bundle install cleanup(not to be confused withbrew bundle install --cleanup!)brew bundle cleanup installmax: 1annotation for named args because this would breakbrew bundle execI wrote this commit as part of my abortive effort on zsh completion. Sending the PR anyway, because imo it's still an improvement to usability and will be of some assistance if anyone continues working on completions for
brew bundle.