Start signing internal v3 json #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the PR on the main brew repo got merged in we're generating the internal v3 JSON but we're not storing or using it anywhere. This updates the scheduled generation task to not only store the resulting JSON but also sign it to allow us to use it as a reference when building the loader code.
Bo98
approved these changes
Feb 4, 2024
|
Thanks @apainintheneck! |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the PR on the main brew repo got merged in we're generating the internal v3 JSON but we're not storing or using it anywhere. This updates the scheduled generation task to not only store the resulting JSON but also sign it to allow us to use it as a reference when building the loader code.