Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly mark non-private APIs. #17128

Merged
merged 3 commits into from Apr 23, 2024

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Apr 22, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Prerequisite for #16831.

@reitermarkus reitermarkus force-pushed the docs-api-public branch 3 times, most recently from f81aff1 to 71de8fc Compare April 22, 2024 19:13
@reitermarkus reitermarkus force-pushed the docs-api-public branch 12 times, most recently from 80ccf50 to 321ee51 Compare April 22, 2024 19:58
Library/Homebrew/tap.rb Outdated Show resolved Hide resolved
reitermarkus and others added 2 commits April 23, 2024 02:07
Co-authored-by: Eric Knibbe <[email protected]>
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @reitermarkus! Merging now to avoid conflicts but feel free to offer post-merge feedback, anyone.

@MikeMcQuaid MikeMcQuaid merged commit 5ad4e6e into Homebrew:master Apr 23, 2024
33 checks passed
@reitermarkus reitermarkus deleted the docs-api-public branch April 23, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants