language/python: order args for virtualenv_install_with_resources
#16817
+304
−124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
without
,start_with
, andend_with
to allow basic control over the order that resources are installed so that the situations where we have to split upvirtualenv_install_with_resources
is reduced.brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?In
homebrew-core
, we've often have to running separate venv commands whenever there is an ordering problem or there are some extra resources that we don't want in venv.In this PR, I am looking into expanding DSL to handle some of these cases.
Examples usage can include:
jupyterlab
:awscli
I added an exception in case that resource name doesn't exist, but can remove if we want to just ignore these.
EDIT: Probably need to view test diff without whitespace as I ended up indenting existing
Language::Python::Virtualenv::Virtualenv
(https://github.com/Homebrew/brew/pull/16817/files?diff=unified&w=1)