Simplify Tap#cask_files_by_name.
#16775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apainintheneck
approved these changes
Mar 1, 2024
| @@ -588,8 +588,7 @@ def self.default_path(token) | |||
| def self.find_cask_in_tap(token, tap) | |||
| filename = "#{token}.rb" | |||
|
|
|||
| Tap.cask_files_by_name(tap) | |||
| .fetch(token, tap.cask_dir/filename) | |||
| tap.cask_files_by_name.fetch(token, tap.cask_dir/filename) | |||
There was a problem hiding this comment.
Suggested change
| tap.cask_files_by_name.fetch(token, tap.cask_dir/filename) | |
| tap.cask_files_by_name.fetch(token) { tap.cask_dir/filename } |
Nit: You could use a block here to avoid building Pathname objects when the result is in the hash.
There was a problem hiding this comment.
@apainintheneck Seems like a good follow-up PR if it has any measurable performance impact.
There was a problem hiding this comment.
I don't have any benchmarks to back this up but we have had a lot of performance problems related to creating loads of Pathname objects before. It just seemed like an easy way to avoid that.
There was a problem hiding this comment.
@apainintheneck Ok, thanks, will bear that in mind in future.
MikeMcQuaid
approved these changes
Mar 1, 2024
| @@ -588,8 +588,7 @@ def self.default_path(token) | |||
| def self.find_cask_in_tap(token, tap) | |||
| filename = "#{token}.rb" | |||
|
|
|||
| Tap.cask_files_by_name(tap) | |||
| .fetch(token, tap.cask_dir/filename) | |||
| tap.cask_files_by_name.fetch(token, tap.cask_dir/filename) | |||
There was a problem hiding this comment.
@apainintheneck Seems like a good follow-up PR if it has any measurable performance impact.
apainintheneck
added a commit
that referenced
this pull request
Mar 2, 2024
We essentially stopped caching these accidentally and they get called every time we try to load a cask or formula from the API. It gets really, really, really slow. I ran `brew deps --casks --eval-all` before and after the changes. I let it run for 3 minutes before killing it. No output had been printed to the screen. It finished printing all output (pages and pages of it) in less than a minute. --- This should match the caching behavior we had before the recent changes in these two PRs. - #16777 - #16775
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Extracted from #16730 for easier review.