Generate internal cask json v3 #16514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a slimmer JSON representation that omits unnecessary fields. The goal here is to reduce download file size and JSON loading times.
This represents the state of the core cask tap when this got generated.
|
Moving back to draft since the discussion in #16460 is relevant for this PR and could result in changes to naming among other things. |
MikeMcQuaid
reviewed
Jan 22, 2024
| api_hash = to_hash_with_variations.except( | ||
| # Included in the top-level of the `internal_cask_v3.json` file | ||
| # created by the `brew generate-cask-api` command. | ||
| "old_tokens", |
There was a problem hiding this comment.
- Unless I'm mistaken:
tokenandfull_tokenare always identical, too. url_specs,languagesseem to be often empty.- stuff like
appcastis oftennull installedandinstalled_timeandoutdatedare reflective of the machine they are run on and not public API.
There was a problem hiding this comment.
appcast is deprecated, if it's not null it should be.
|
Closing because the approach in the formula PR changed significantly which means this will need to be reworked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This is a sister PR to #16460. It start generating the
internal_cask_v3.jsonfile in thebrew generate-cask-apifile.I didn't add any tests because they'll be easier to add later on when working on the cask loading code in the near future. The main thing here is that this doesn't break the
brew generate-cask-apicommand which is easy to test.I took the same approach as the other PR to cache the variations generation so the runtime of this command should be similar to what it was before.
The file size difference is significant but the old file wasn't as large as with formulae. It reduces the size from around 6MB to 4MB.
Related to: #16410