Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node_modules to .gitignore file #483

Closed
wants to merge 1 commit into from

Conversation

ahmdyasser
Copy link

node_modules folder is generated when install JS packages, it shouldn't be part of the repo.

@Bo98
Copy link
Member

Bo98 commented Jan 26, 2024

It is necessary for the GitHub Actions to run, as shown by the failing CI here. The alternative is bundling the dependencies into a dist file (like how GitHub's own actions work) but is ultimately the same result.

@ahmdyasser ahmdyasser closed this Jan 26, 2024
@ahmdyasser
Copy link
Author

@Bo98 Got it now, thank you

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants