Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract 5 digit Segment ID from (some) ≥FV2410 AHBs #309

Merged
merged 6 commits into from
May 20, 2024
Merged

Extract 5 digit Segment ID from (some) ≥FV2410 AHBs #309

merged 6 commits into from
May 20, 2024

Conversation

hf-kklein
Copy link
Contributor

@hf-kklein hf-kklein commented May 19, 2024 •
edited
Loading

#304
Fixes:

ERROR [kohlrahbi] Error processing pruefi '55109': The data_element '00003' does not match re.compile('^\d{4}$')

@hf-kklein hf-kklein requested a review from hf-krechan May 20, 2024 07:05
@hf-kklein hf-kklein changed the title Add Test Case for Parsing of Segment ID Extract 5 digit Segment ID from (some) ≥FV2410 AHBs May 20, 2024
hf-kklein
hf-kklein commented May 20, 2024
View reviewed changes
src/kohlrahbi/unfoldedahb/unfoldedahbtable.py
Comment on lines +180 to +181
datenelement=_split_data_element_and_segment_id(row["Datenelement"])[0],
segment_id=_split_data_element_and_segment_id(row["Datenelement"])[1],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich gebe zu, das ist mittel hässlich. aber so hat pylint nicht gejammert, es gäbe zu viele locals ;)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough ;)

@hf-kklein hf-kklein marked this pull request as ready for review May 20, 2024 07:09
@hf-kklein hf-kklein self-assigned this May 20, 2024
@hf-kklein hf-kklein linked an issue May 20, 2024 that may be closed by this pull request
Save unique \d{5} segment ID (light grey number in AHB in >=FV2410) #304
Closed
hf-krechan
hf-krechan approved these changes May 20, 2024
View reviewed changes
src/kohlrahbi/unfoldedahb/unfoldedahbtable.py
Comment on lines +180 to +181
datenelement=_split_data_element_and_segment_id(row["Datenelement"])[0],
segment_id=_split_data_element_and_segment_id(row["Datenelement"])[1],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough ;)

@hf-kklein hf-kklein merged commit be97b58 into main May 20, 2024
10 checks passed
@hf-kklein hf-kklein deleted the d5-parsing branch May 20, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf-krechan hf-krechan hf-krechan approved these changes

@DeltaDaniel DeltaDaniel Awaiting requested review from DeltaDaniel

Assignees

@hf-kklein hf-kklein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save unique \d{5} segment ID (light grey number in AHB in >=FV2410)
2 participants
@hf-kklein @hf-krechan