馃Ч Switch to mypy --strict
#308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
commented
May 17, 2024
| @@ -36,7 +36,7 @@ deps = | |||
| -rrequirements.txt | |||
| -r dev_requirements/requirements-type_check.txt | |||
| commands = | |||
| mypy --show-error-codes src/kohlrahbi | |||
| mypy --show-error-codes src/kohlrahbi --strict | |||
| mypy --show-error-codes unittests | |||
There was a problem hiding this comment.
unittests strict zu linten ist ne flei脽aufgabe f眉r einen anderen tag
lord-haffi
approved these changes
May 17, 2024
hf-krechan
reviewed
May 17, 2024
| @@ -48,7 +48,7 @@ def table_header_starts_with_text_edifact_struktur(table: Table) -> bool: | |||
| return table.cell(row_idx=0, col_idx=0).text.strip() == "EDIFACT Struktur" | |||
|
|
|||
|
|
|||
| def is_item_header_of_change_history_section(item: Paragraph | Table | None, style_name: str) -> bool: | |||
| def is_item_header_of_change_history_section(item: Paragraph | Table | None, style_name: str) -> TypeGuard[Paragraph]: | |||
There was a problem hiding this comment.
Why is this not a bool?
This questions is also valid for the other is_... function
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.