Skip to content

Commit

Permalink
Use default_factories
Browse files Browse the repository at this point in the history
  • Loading branch information
hf-kklein committed May 20, 2024
1 parent a42f3ea commit 3e93ad2
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions src/kohlrahbi/ahbtable/ahbcondtions.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

from docx.table import Table as DocxTable
from maus.edifact import EdifactFormat
from pydantic import BaseModel, ConfigDict
from pydantic import BaseModel, ConfigDict, Field

from kohlrahbi.logger import logger

Expand All @@ -16,7 +16,7 @@ class AhbConditions(BaseModel):
Class which contains a dict of conditions for each edifact format
"""

conditions_dict: dict[EdifactFormat, dict[str, str]] = {}
conditions_dict: dict[EdifactFormat, dict[str, str]] = Field(default_factory=dict)

model_config = ConfigDict(arbitrary_types_allowed=True)

Expand Down
12 changes: 6 additions & 6 deletions src/kohlrahbi/seed.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"""

from docx.table import Table
from pydantic import BaseModel
from pydantic import BaseModel, Field

from kohlrahbi.enums import RowType
from kohlrahbi.table_header import PruefiMetaData, TableHeader, get_tabstop_positions
Expand All @@ -15,13 +15,13 @@ class Seed(BaseModel):
helper class to store all values to extract the AHB and the final AHB as dataframe
"""

pruefidentifikatoren: list[str] = []
column_headers: list[str] = []
pruefidentifikatoren: list[str] = Field(default_factory=list)
column_headers: list[str] = Field(default_factory=list)
edifact_struktur_left_indent_position: int = 0
middle_cell_left_indent_position: int = 0
tabstop_positions: list[int] = []
last_two_row_types: list[RowType] = []
metadata: list[PruefiMetaData] = []
tabstop_positions: list[int] = Field(default_factory=list)
last_two_row_types: list[RowType] = Field(default_factory=list)
metadata: list[PruefiMetaData] = Field(default_factory=list)

# why this classmethod?
# to decouple the data structure of Elixir from the input data
Expand Down
4 changes: 2 additions & 2 deletions src/kohlrahbi/table_header.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from docx.table import _Cell
from docx.text.paragraph import Paragraph
from more_itertools import first, last
from pydantic import BaseModel
from pydantic import BaseModel, Field


class HeaderSection(StrEnum):
Expand Down Expand Up @@ -93,7 +93,7 @@ class TableHeader(BaseModel):
It contains the information about the Prüfidentifikatoren.
"""

pruefi_meta_data: List[PruefiMetaData] = []
pruefi_meta_data: List[PruefiMetaData] = Field(default_factory=list)

@classmethod
def from_header_cell(cls, row_cell: _Cell) -> "TableHeader":
Expand Down

0 comments on commit 3e93ad2

Please sign in to comment.