Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding accept all tradeoffers button #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rchutzz
Copy link
Collaborator

@rchutzz rchutzz commented Jul 10, 2023

Hello,

I had issues with confirmations not loading because of steam authentication issues.

  1. Resolved by updating npm update steamcommunity
  2. Added border/ width of size 12 to the renderConfirmations steam avatar to prevent image overflow
  3. Added a button Accept All to accept all trade confirmations.
    4. Seperate request for changes to main.yml*

Screen Shot 2023-07-09 at 5 42 43 PM

For people who sell a lot of items on buff.163 or other marketplaces, this will allow users to automate accepting tons of confirmations at once (3 second delay that waits for promise to resolve). might need to add a warning that people are vunerable to API scams shouldn't use this feature.

I realized the main.yml file attempt to use node v10.x, but was incompatible with the updated dependencies. I made another pull request to update the main.yml to use v14.x to allow this branch to successful pass the tests to be able to merge with the master.

@rchutzz
Copy link
Collaborator Author

rchutzz commented Jul 10, 2023

@HilliamT currently blocked by the pullrequest to update main.yml

@rchutzz rchutzz requested a review from HilliamT July 10, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant