Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft at creating specific columns widths #1117

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

RoyMudie
Copy link
Contributor

No description provided.

@@ -68,6 +68,7 @@ public virtual void OnNotify(object sender, NotifyEventArgs e)
case ProgressEventType.Debug:
break;
case ProgressEventType.Information:
case ProgressEventType.Success:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I theres going to be a LOT of case statements like this you will need to update in RDMP to add a new value to this enum. Also the order of the Enum is important there are code which says things like if worst <= Warning so creating a value of Success that is higher than Error as a raw value is very bad. Adding the Success at the same level as Information will be a breaking change for plugins which will require full refresh so that they get the new enum value into the compiled dll (basically old dlls won't work with new RDMP after this change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants