Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix DXVK uninstallation from prefix #3760

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

casasfernando
Copy link
Contributor

Fix DXVK uninstallation by restoring Wine/Proton DLLs after DXVK DLL overrides are removed. Otherwise wineboot -u will have to be executed to achieve the same result.
Fixes #3707 .

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented May 17, 2024

wine will use wined3d if the overrides were removed properly, something is not working right with your wine installation as I have tested this hundreds of times at this point, and it works without needing to do this. But this is good to have anyway.

@casasfernando
Copy link
Contributor Author

I’m not doing anything special to be honest. It’s also documented here: https://github.com/doitsujin/dxvk#how-to-use 🤷🏻‍♂️

For what it worth I found this issue while playing on a PC with an Intel iGPU which doesn’t have great Vulkan support. Only way to stop using DXVK and go back to WineD3D was to also restore the DLLs.
On the Steam Deck for example the problem went unnoticed for me because the APU will handle both fine.

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented May 18, 2024

I’m not doing anything special to be honest. It’s also documented here: doitsujin/dxvk#how-to-use 🤷🏻‍♂️

For what it worth I found this issue while playing on a PC with an Intel iGPU which doesn’t have great Vulkan support. Only way to stop using DXVK and go back to WineD3D was to also restore the DLLs. On the Steam Deck for example the problem went unnoticed for me because the APU will handle both fine.

never said you were doing anything special, I am just saying that this change should not be nessessary.

yes but I have carefully checked with the toggle on and off, wine will load dlls from where its dlls are stored not the prefix. I used mangohud and also checked logs

@casasfernando
Copy link
Contributor Author

I understand and thanks for the feedback @Etaash-mathamsetty . Maybe it is something wrong with my setup. I still think this PR adds some value and it certainly helps in my scenario.
Of course is up to the team to accept it or not. In any case I would also really appreciate feedback on the PR code itself if any since I’m always looking to improve my coding skills.

Thanks.

@Etaash-mathamsetty Etaash-mathamsetty added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto Install/Update DXVK on Prefix setting is not correctlly removing DXVK when unchecked
2 participants