Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip.add_cell: allow specifying the magnification of the added cell #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fbeutel
Copy link
Contributor

@fbeutel fbeutel commented Jan 25, 2022

No description provided.

@HelgeGehring
Copy link
Owner

Thanks!
I think I left this parameter out, as not all functions are considering the value yet.
It should be implemented in

  • get_bonds
  • get_reduced_layer
  • save
  • get_patches
    to not cause inconsistencies.
    Before we add the parameter, I think we should implement it (or add a warning to the functions which ignore magnification if magnification is used)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants