Fix FlxBGSprite render on camera zoom != 1 #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can I get a simple scenario that showcases this change? NVM, made my own |
Geokureli
reviewed
Jun 10, 2024
flixel/system/FlxBGSprite.hx
Outdated
Comment on lines
23
to
25
| if (alpha == 0.0) | ||
| return; | ||
|
|
There was a problem hiding this comment.
I see no reason for this class to check this when all other FlxSprites do not. This change will only serve to confuse people who expect this to behave exactly like other FlxSprites. I also would not want this change made in FlxSprite, I recommend either setting visible to false, manually to prevent draw calls, or making an extending class in your program that has this change
Suggested change
| if (alpha == 0.0) | |
| return; |
There was a problem hiding this comment.
also this wouldn't have had any effect, since the sprite's alpha is typically 1.0, even with a transparent bgColor. Changing the substate's bgColor only changes the sprite's pixel color
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additionally skip draw call if alpha is 0