Extend check_dns.pl so it can take a list of domains #338
Conversation
…he same expected result
|
Kudos, SonarCloud Quality Gate passed!
|
| $msg .= join("','", @results_uniq); | ||
| } | ||
| $msg .= "'"; | ||
| $msg .= " | dns_query_time='${call_time}s'" if $verbose; |
There was a problem hiding this comment.
this will mess up in --verbose mode
|
|
||
| my $stop_calls = time; | ||
| my $total_time = sprintf("%.4f", $stop_calls - $start_calls); | ||
| my $perfdata = "\n | total_dns_query_time='${total_time}s'"; |
There was a problem hiding this comment.
multi-line will break some monitoring servers output
| } | ||
| @regex_mismatches = sort(uniq_array(@regex_mismatches)) if(@regex_mismatches); | ||
| $msg .= "\n$records[$i] $type record "; |
There was a problem hiding this comment.
multi-line will break some monitoring servers output / dashboards as traditionally only 1 line is guaranteed to be displayed, you wouldn't want the output on some systems to be "DNS OK:" and nothing else...
|
Thanks for the pull request. Overall the changes look ok, just needs some tweaking of the output formatting to maintain 1 line dashboard compatibility, verbose mode testing etc. |
|
Thanks for the feedback. I will change it to only output one line and remake this pull request from a different account. I used this account by mistake. |
|
This is my new account. Here is the new pull request #339 |
|
I am sorry for the bother of creating a new request instead of just committing the fixes here. But I am in the process of de-googling and is trying to remember not to use my old google accounts eveywhere. |
Extend check_dns.pl so it can take a list of domains that each have the same expected results.
I have many servers with even more websites, some servers have many websites. I want a single check for each server that checks all the websites on that server.