Do not select the extension when refactoring file names

[jojo2357]

Fix #3551

So. The simplest solution was to simply make a custom Rename Processor that would gobble up ALL PsiFiles and automatically null the editor. This has the side effect of making every file refactor not select the extension by default, which covers my issue, but may cause problems?

I tested, every \input will have this behavior (which IMO is just another manifestation of this issue), refactoring commands from \newcommand is unaffected.

Attempting to refactor a package does not work.

Let me know if we need to go ahead and actually implement more logic. If anything, this opens the door to smarter refactoring?

\includegraphics{IM<caret>G.jpg}

[PHPirates]

Good find! I think to be on the safe side, we should indeed do some smarter refactoring to only not select the text after the dot if we know the command is referencing a file name, so something like this:

    override fun createRenameDialog(project: Project, element: PsiElement, nameSuggestionContext: PsiElement?, editor: Editor?): RenameDialog {
        return object : PsiFileRenameDialog(project, element, nameSuggestionContext, editor) {
            override fun createNewNameComponent() {
                super.createNewNameComponent()
                // if psi element references a file name:
                nameSuggestionsField.selectNameWithoutExtension()
            }
        }
    }

[jojo2357]

override fun canProcessElement(element: PsiElement): Boolean {
    return when (element) {
        is PsiFile -> true
        else -> true
    }
}

but it only runs on Files, and is only a rename refactorer, what other cases are there?

[PHPirates]

I don't understand that code snippet, it's just return true?
In general, even though it might not have any (known) side effects at the moment, it might change in the future so I would prefer the more restricted code of only setting the editor to null if we are renaming a file name and not something else.

[jojo2357]

Oops, dont know how i missed that. ofc the else should be false 😑

[PHPirates]

Ah okay, then yes if you set editor to null only if the psi element is a PsiFile, if that works then I can agree to that.

[jojo2357]

I checked and it still works with the else branch being false.

Ready to go

[PHPirates]

Thanks! I just added a comment to explain