-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Argon2id KDF #23
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add argon2 to requirements.txt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move import argon2
to its own try: / except ModuleNotFoundError:
block with an updated exception message.
Feel free to take the code over if you are interested and modify as you wish. Unfortunatelly, I do not have time to make it 100%. |
So far I'm only seeing 2 tiny changes needed. |
I have corrected these two points and tested that. In the requirements I added version of the library I'm able to confirm to be working. It will probably work already from version 16.3.0, but I cannot verify that. |
I'm curious, where does this PR stand? I see the requested changes were made. Can this be merged? |
Oh, I see it's not actually working. I can't decrypt my export with this. |
Hi, let me know, what is not working for you. Resp. what are you decrypting and how. It is working for me fine.David8. 6. 2023 v 18:19, Ray Kohler ***@***.***>:
Oh, I see it's not actually working. I can't decrypt my export with this.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I have a password-protected export with fields like this:
When I try to decrypt it:
I am on OpenBSD and I installed the needed python modules from OpenBSD's repository. |
I just tested the same on Ubuntu 22.04 and it didn't work there either. |
Sorry @ataraxia937 I haven't had time to get back this. Will try to finish I the next 2 weeks. There was some refactor and other changes I wanted to make before merging into main. |
I have just tested the code on my Ubuntu 20.04 and it is working OK for me both for data.json synced via CLI as well as password protected export. |
Yes, I'm using the official Bitwarden server, so that explains it.
…On Thu, Jun 8, 2023 at 1:03 PM Davek145 ***@***.***> wrote:
I have just tested the code on my Ubuntu 20.04 and it is working OK for me
both for data.json synced via CLI as well as password protected export.
However, I use Vaultvarden. It shall have the same format of the file as
the official Bitwarden as the Webvault is the same (I'm now on verion
2023.3.0), but I cannot test it.
What looks strange to me is, that you claim to test it on password
protected export, but he your file has kdfType = 1, so argon2. If I make
password protected export, it always uses pbkdf2. Argon2 is only used for
directcly synced data.json file from my server.
If you try it on official Bitwarden server, may be they have changed
something with the password protected export that Vaultwarden is not yet
using. Try it also on synced data.json that is having data in better format
and also including organization entries.
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA6RYWIXJBJJM5WGEL7AO3XKIAVLANCNFSM6AAAAAAVIU77IE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Healthcare & Life Science Equipment Service Solutions are our *only*
business.*
|
This branch is working well for me using Argon2 in official Bitwarden. @ataraxia937 the name of the file you are attempting to decrypt (bitwarden_encrypted_export_20230608111639.json) indicates it is likely a bitwarden export file, decrypting exports is not something supported by this project anyway (according to the readme) and is most likely the reason for it not working for you, you need to instead use the data.json file (from the Desktop App).
|
Support for Argon2 KDF added in Bitwarden 2023.2.0. It is utilizing argon2-cffi library.