feat#116: int with default thresholds #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwoytenko
requested changes
May 22, 2024
| @@ -17,7 +18,7 @@ type NoiseTimestampLimiter struct { | |||
| func NewNoiseTimestampLimiter(minDate, maxDate *time.Time) (*NoiseTimestampLimiter, error) { | |||
|
|
|||
| if minDate != nil && maxDate != nil && minDate.After(*maxDate) { | |||
| return nil, ErrWrongLimits | |||
| return nil, int_utils.ErrWrongLimits | |||
There was a problem hiding this comment.
Consider adding another import alias, because int_utils contains not only integer utils
| } | ||
|
|
||
| if minValue == 0 { | ||
| minValue = minThreshold |
There was a problem hiding this comment.
The 0 value might be received from parameters. Consider the way how to overcome this obstacle. For instance, we would receive the values by pointer and if there is a nil, then set default value thresholds.
Parameterizer interface provides the next method
IsEmpty() (bool, error)You can check that the value is empty if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One problem: possibly the id as it might be negative. Maybe I need to add some constraints for ID type.