Created Add/Del SceneTag exec for quests | Fixed Filters for WorldBoss checking first ID only #2511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 missing classes for adding and deleting sceneTags in quests
Edit: im not sure how to make it take 1 commit only so i guess its 2 fixes then.
Description
Issue 1:
Added 2 missing Execute Classes for quests for adding and deleting sceneTag.
[src/main/java/emu/grasscutter/game/quest/exec/ExecAddSceneTag.java]
[src/main/java/emu/grasscutter/game/quest/exec/ExecDelSceneTag.java]
Issue 2:
Fixed Filters on InvestgationMonsters Rewards checking only the first Boss ID
[src/main/java/emu/grasscutter/game/world/WorldDataSystem.java]
Issues fixed by this PR
Issue 1:
World quests such as (Seirai Stormchasers) changing sceneTag such as the Thunder Manifestation platform would not change after finishing the quest.
Issue 2:
getRewardByBossId was checking with filters and using FindFirst and get[0] which caused Multi Variant Bosses to give error "Could Not found the reward of boss monster id"
Example of bosses effected is Primo Geovishap would only get rewards for the first boss "hydro" but not the other variants.
Type of changes
Checklist: