Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Add/Del SceneTag exec for quests | Fixed Filters for WorldBoss checking first ID only #2511

Closed
wants to merge 4 commits into from

Conversation

ShiroySan
Copy link

@ShiroySan ShiroySan commented May 15, 2024

Added 2 missing classes for adding and deleting sceneTags in quests

Edit: im not sure how to make it take 1 commit only so i guess its 2 fixes then.

Description

Issue 1:
Added 2 missing Execute Classes for quests for adding and deleting sceneTag.
[src/main/java/emu/grasscutter/game/quest/exec/ExecAddSceneTag.java]
[src/main/java/emu/grasscutter/game/quest/exec/ExecDelSceneTag.java]

Issue 2:
Fixed Filters on InvestgationMonsters Rewards checking only the first Boss ID
[src/main/java/emu/grasscutter/game/world/WorldDataSystem.java]

Issues fixed by this PR

Issue 1:
World quests such as (Seirai Stormchasers) changing sceneTag such as the Thunder Manifestation platform would not change after finishing the quest.

Issue 2:
getRewardByBossId was checking with filters and using FindFirst and get[0] which caused Multi Variant Bosses to give error "Could Not found the reward of boss monster id"

Example of bosses effected is Primo Geovishap would only get rewards for the first boss "hydro" but not the other variants.

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@ShiroySan ShiroySan changed the title Created Add/Del SceneTag exec for quests Created Add/Del SceneTag exec for quests May 15, 2024
@ShiroySan ShiroySan changed the title Created Add/Del SceneTag exec for quests Created Add/Del SceneTag exec for quests | Fixed Filters for WorldBoss checking first ID only May 15, 2024
@ShiroySan ShiroySan closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant