Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Up doc.write to element.innerHTML #5815

Closed
wants to merge 1 commit into from
Closed

Up doc.write to element.innerHTML #5815

wants to merge 1 commit into from

Conversation

WooRung
Copy link

@WooRung WooRung commented Apr 17, 2024

remove warning on recent chrome

@WooRung
Up doc.write to element.innerHTML
81b0773 
remove warning on recent chrome
artf
artf requested changes Apr 19, 2024
View reviewed changes
Copy link
Member

@artf artf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the same thing. With this change the default <!DOCTYPE html> won't be rendered and that changes the way the iframe is rendering the content.

Screenshot 2024-04-19 at 19 02 58

@artf artf added the inactive label May 21, 2024
@artf artf closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artf artf artf requested changes

Assignees
No one assigned
Labels
inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WooRung @artf