Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed skip_if_private and skip_if_public check #373

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xDope7137
Copy link

Description

skip_if_public and skip_if_private were wrong.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ X ] Test A
  • [ X ] Test B

Test Configuration:

  • Device Model or Emulator: Samsung S20
  • Android Verison: 14
  • Instagram Version: Recommended

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested my code in every way I can think of to prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

logger.info(
f"@{username} has public account and you want to interact only private, skip.",
f"@{username} has private account and you want to interact only pubic, skip.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also want to interact only pubic :D
correct the typo

logger.info(
f"@{username} has public account and you want to interact only private, skip.",
f"@{username} has private account and you want to interact only pubic, skip.",
extra={"color": f"{Fore.CYAN}"},
)
return profile_data, self.return_check_profile(
username, profile_data, SkipReason.IS_PUBLIC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the skip reason is now that is private

logger.info(
f"@{username} has private account and you want to interact only public, skip.",
f"@{username} has public account and you want to interact only private, skip.",
extra={"color": f"{Fore.CYAN}"},
)
return profile_data, self.return_check_profile(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here you have to change the skip reason from private to public

@mastrolube
Copy link
Contributor

can you do these changes so we can merge? :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants