Create Invest Address model and form #437
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new model for the invest address table and the symfony form needed to handle all the data that the user has to give.
The problem with this PR is that it's really soft spot in all the donation process of the platform.
The page were this data is added has the data of two different models. First, all the data related to the donor fiscal information, and then the information for the invest address.
We should create two forms but handle them as one, how can we do that? Should be create another step in the process? Will it the too long for the user?
Also, at first, i had created the model as a new Entity, but the code in the Controller to handle form creations is binded to the Model class.
Also, this views are used in the core application and also inside private zones of goteo. I would like to have a discussion in this topic prior to advance with this development.