Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT]: feat: allow updating export options at runtime #974

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[DRAFT]: feat: allow updating export options at runtime #974

wants to merge 1 commit into from

Conversation

TheSpiritXIII
Copy link
Member

  1. Lease was moved to the Exporter, rather than the ExporterOpts, since this is a static option.
  2. ApplyConfig now takes ExporterOpts, which allows runtime updates.
  3. exporter.New now takes a context and Run no longer does, which means the Exporter uses the same context throughout its lifetime.

These changes allow us to update the metric client at runtime. When a metric client is updated, it may take:

  • 50ms worse case, when not enough samples are being exported to fill a batch.
  • <50ms best case, when many samples (>200) are being written

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@TheSpiritXIII