[DO NOT MERGE] Upgrade to yaml v3 #688
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upon further review, this would be a risky change to merge. The reason being is that the yaml library is no longer maintained. Kubernetes is looking into forking it, but until then, this would be a breaking change. Here's why: v2 serializes an object such as: array:
- map
key1: value1While v3 would serialize the same object as: array:
- map
key1: value1Both are valid YAML and there is no way to customize this on the library-level. If the user does absolutely nothing, this may break a user's scraping completely. For example, if this change brings the user's config over the 1 MiB limit for ConfigMaps, the user will have to enable compression if they even realize their scraping broke. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One less dependency to manage.