Added requests resources to examples/example-app.yaml #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #536 Signed-off-by: bwplotka <[email protected]>
TheSpiritXIII
approved these changes
Jul 28, 2023
| @@ -52,3 +53,7 @@ spec: | |||
| - "/main" | |||
| - "--process-metrics" | |||
| - "--go-metrics" | |||
| resources: | |||
| requests: | |||
| cpu: 100m | |||
There was a problem hiding this comment.
This is significantly higher than other applications we have. Is the example app really more resource intensive than prometheus?
There was a problem hiding this comment.
Not really, but not sure if it matters as long as it's not something ridiculous by default (500m)
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| memory: 100Mi |
There was a problem hiding this comment.
Same here. We give our operator 32M. Did you check actual usage?
There was a problem hiding this comment.
No, will check, but I don't think that's important as long as it's not 2GBi (default on my autopilot cluster)
pintohutch
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #536