added example to host a static website on GCS and containerized backend on MIG #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakeebshams
suggested changes
Jul 14, 2023
|
|
||
| ## Create the A record for your domain | ||
|
|
||
| From the outputs, copy the IP address of the newly created load balancer. Register a new A record with yoru domain provider. The domain must be an exact match to the one you set as variable before running the script. |
There was a problem hiding this comment.
Suggested change
| From the outputs, copy the IP address of the newly created load balancer. Register a new A record with yoru domain provider. The domain must be an exact match to the one you set as variable before running the script. | |
| From the outputs, copy the IP address of the newly created load balancer. Register a new A record with your domain provider. The domain must be an exact match to the one you set as variable before running the script. |
small nit
|
|
||
| Authenticate against Artifact Registry: | ||
|
|
||
| `gcloud auth configure-docker REGION.pkg.dev` |
There was a problem hiding this comment.
The line should read
Suggested change
| `gcloud auth configure-docker REGION.pkg.dev` | |
| `gcloud auth configure-docker REGION-docker.pkg.dev` |
| [Service] | ||
| Environment="HOME=/home/nginx" | ||
| ExecStartPre=/usr/bin/docker-credential-gcr configure-docker --registries REGION-docker.pkg.dev | ||
| ExecStart=/usr/bin/docker run --rm --name webserver -p 80:80 /usr/bin/docker run --rm --name webserver -p 80:80 REGION.pkg.dev/gPROJECT_ID/image-repo/webserver:v1 |
There was a problem hiding this comment.
Is it intended for the /usr/bin/docker run --rm --name webserver -p 80:80 to run twice on this line
There was a problem hiding this comment.
@annamuscarella If you can resolve the suggestions, I can probably get this merged for you.
|
Closed as stale. Please re-open if I'm wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an example that creates a load balancer which serves a static frontend hosted on GCS and containerized NodeJS backend hosted on a MIG.