Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: Test Machine Learning Image #1684

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Internal: Test Machine Learning Image #1684

wants to merge 20 commits into from
+26 −3

Conversation

Subbarker
Copy link
Contributor

@Subbarker Subbarker commented Apr 23, 2024 •
edited by igorpeshansky

Description

This image is used for ML workloads.

Related issue

b/301084986

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@Subbarker Subbarker changed the title Test ml-images:common-gpu-debian-11-py310 Internal: Test ml-images:common-gpu-debian-11-py310 Apr 23, 2024
@Subbarker Subbarker changed the title Internal: Test ml-images:common-gpu-debian-11-py310 Internal: Test ml-images:common-cu118-debian-11-py310 May 9, 2024
@Subbarker Subbarker changed the title Internal: Test ml-images:common-cu118-debian-11-py310 Internal: Test Machine Learning Image May 9, 2024
igorpeshansky
igorpeshansky reviewed May 30, 2024
View reviewed changes
integration_test/ops_agent_test/main_test.go Outdated
return nil
} else {
cmd = `
sudo rm -rf /usr/local/go || true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since rm is run under sudo, when would it have a non-zero exit code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When go isn't installed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what the -f flag is for, right? It should not fail for nonexistent files.

integration_test/ops_agent_test/main_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpeshansky igorpeshansky igorpeshansky left review comments

@jefferbrecht jefferbrecht jefferbrecht left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Subbarker @igorpeshansky @jefferbrecht