Fix all go-staticcheck warnings

[braydonk]

Description

This PR fixes all present go-staticcheck warnings in the codebase.

Everyone who I've requested a PR from was the last editor of code that was addressed according to a git blame.

Related issue

How has this been tested?

Confgenerator unit tests.

Checklist:

• Unit tests
  • Unit tests do not apply.
  • Unit tests have been added/modified and passed for this PR.
• Integration tests
  • Integration tests do not apply.
  • Integration tests have been added/modified and passed for this PR.
• Documentation
  • This PR introduces no user visible changes.
  • This PR introduces user visible changes and the corresponding documentation change has been made.
• Minor version bump
  • This PR introduces no new features.
  • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
  • This PR bumps the version.

[quentinmit]

Why are there changes in the golden files? If the output is changing, that's not just a lint change.

A number of these changes appear to be creating inconsistencies between similar functions (e.g. it appears to have removed unused function parameters, so now there are some functions that take (a, b, c) and other functions that just take (a, c) based on the current implementation of that function. I don't think that's actually an improvement.

[braydonk]

Why are there changes in the golden files?

Most of the goldens that are changing are removing punctuation from errors. The only valid output that changed is oracledb because there was trailing whitespace in the file that my editor trims automatically.

A number of these changes appear to be creating inconsistencies between similar functions

This is because of the unused parameters check in gopls. These functions weren't using the context that was passed in, and since they aren't bound by any interface I removed them from the argument list.

I'm fine with turning off the error formatting check to restore goldens to their original form. For the unused parameters, we could use _ for those, but it seems arbitrary if they aren't bound by satisfying some interface. But using _ for context arguments is probably a fine heuristic.