Add presubmits for compositions #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barney-s
force-pushed
the
composition-presubmits
branch
9 times, most recently
from
3aa8552
to
dd0760e
Compare
barney-s
force-pushed
the
composition-presubmits
branch
from
dd0760e
to
b4ef38b
Compare
- Add github action targetting experiments/** - Run tests for jinja expander - Run e2e tests - fix test data in compositions to trigger tests - increase timeouts for reducing flakes
barney-s
force-pushed
the
composition-presubmits
branch
from
b4ef38b
to
7c2223c
Compare
|
/assign @acpana |
acpana
reviewed
May 16, 2024
|
/hold if you want experiments/ compositions specific input too but it LGTM overall /lgtm |
|
/unhold |
Co-authored-by: alex <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acpana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
google-oss-prow
bot
merged commit d79b872
into
GoogleCloudPlatform:master
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Add presubmits for compositions.