Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Update llm_immutable_field test http log and exported object #1807

Merged

Conversation

gemmahou
Copy link
Collaborator

Change description

Fixes #

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@gemmahou gemmahou changed the title WIP: Update llm_immutable_field test http log and exported object tests: Update llm_immutable_field test http log and exported object May 16, 2024
@yuwenma yuwenma added this to the 1.119 milestone May 16, 2024
@acpana
Copy link
Collaborator

acpana commented May 22, 2024

Thanks for this 💯

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label May 22, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acpana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 86a55f9 into GoogleCloudPlatform:master May 22, 2024
12 checks passed
@gemmahou gemmahou deleted the fix-scenarios-test branch May 22, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants