chore: update presubmit build-images script to override image names #1801
Conversation
This avoids depending on the current gcloud project (which is likely not set in github actions, at least).
justinsb
force-pushed
the
presubmit_with_known_image
branch
from
22d404a
to
1e8a9e2
Compare
|
Let's sequence this one behind #1799 - I want to rebase on that anyway /hold |
| @@ -19,6 +19,17 @@ set -o pipefail | |||
|
|
|||
| REPO_ROOT="$(git rev-parse --show-toplevel)" | |||
|
|
|||
| # Force the image names, to avoid depending on the current gcloud project | |||
There was a problem hiding this comment.
if we accept this we probably can remove my hack to inject the mockProject id to the GH action steps 😛
|
You don't have to rebase this PR for the CI to run since we are only changing a script file. /hold in case you want to remove the hack for env otherwise I can do it as a follow on maybe. /lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acpana, yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
google-oss-prow
bot
merged commit 05dfab1
into
GoogleCloudPlatform:master
This avoids depending on the current gcloud project (which is likely
not set in github actions, at least).