tests: Introduce internal annotation to force reconciliation #1800
Conversation
justinsb
force-pushed
the
force_reconcile_with_annotation
branch
from
8e6fc44
to
6708226
Compare
|
/hold CI needs #1799 to run or an early sha as base ref. Feel free to cancel as needed. |
pkg/k8s/constants.go
Outdated
| @@ -113,6 +114,9 @@ var ( | |||
| OrgIDAnnotation, | |||
| } | |||
|
|
|||
| // Internal Annotation to force reconciliation | |||
| InternalForceReconcileAnnotation = CNRMInternalGroup + "/reconcile-cookie" | |||
There was a problem hiding this comment.
this may be overkill but do we want to prevent modifying this anon for non test usage?
There was a problem hiding this comment.
I like your change to make it test, it clearly signals that this should not be relied on in prod. If we discover that people are (ab)using it, that's interesting info and we should probably implement a similar production-suitable feature (which might not actually look very different, but .... shrug)
justinsb
changed the title
justinsb
force-pushed
the
force_reconcile_with_annotation
branch
from
b55c68b
to
3d5786f
Compare
The test.cnrm.cloud.google.com/reconcile-cookie annotation can be changed without affecting the "true" desired state, but we special case the annotation in our filtering, so that it still triggers the reconciler. Co-authored-by: alex <[email protected]>
justinsb
force-pushed
the
force_reconcile_with_annotation
branch
from
3d5786f
to
6f3b93f
Compare
|
/lgtm Thank you for the quick fix! (I hit the LLM lazy reconcile flakiness as well). And it is really good to learn the predicate usage with such an example 🌞 |
|
/hold cancel #1799 has been merged. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 040a9a2
into
GoogleCloudPlatform:master
The test.cnrm.cloud.google.com/reconcile-cookie annotation can be
changed without affecting the "true" desired state, but we special-case the annotation in our filtering, so that it still triggers the
reconciler.