[WIP] Properly advertise the client requests. #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @justinsb |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
reviewed
May 9, 2024
...thub.com/hashicorp/terraform-provider-google-beta/google-beta/fwtransport/framework_utils.go
Outdated
Show resolved
Hide resolved
cheftako
force-pushed
the
userAgent
branch
2 times, most recently
from
343f06c
to
29b537c
Compare
Extract the KCC version into its own file. Make it available for embed to pull it in. Make sure that its available in the docker file.
…/google-beta/fwtransport/version.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to work out how to better handle the version information.
Change description
Properly advertise the client requests.
Tests you have done
make ready-prto ensure this PR is ready for review.