chore: refactor unified_test to split out scenario execution #1737
Conversation
Working towards being able to run samples & fixtures the same way.
justinsb
force-pushed
the
harmonize_samples_and_fixtures_step2
branch
from
e231329
to
ce485f6
Compare
| } | ||
|
|
||
| func runScenario(ctx context.Context, t *testing.T, testPause bool, fixture resourcefixture.ResourceFixture, loadFixture func(project testgcp.GCPProject, uniqueID string) (*unstructured.Unstructured, create.CreateDeleteTestOptions)) { | ||
| // Extra indentation to avoid merge conflicts |
There was a problem hiding this comment.
to avoid merge conflicts in this PR 😛 ? or in the future, in which case I'd be curious how this works to fool git diff hehe ? 👀
There was a problem hiding this comment.
Just learnt this trick today 😆
| cancel() | ||
| } | ||
|
|
||
| func runScenario(ctx context.Context, t *testing.T, testPause bool, fixture resourcefixture.ResourceFixture, loadFixture func(project testgcp.GCPProject, uniqueID string) (*unstructured.Unstructured, create.CreateDeleteTestOptions)) { |
There was a problem hiding this comment.
But also could we rename this to runTest? Scenario makes me think of the step/ scenario based testing but if that's on purpose then never mind 😛
There was a problem hiding this comment.
Let's have this PR goes in and then we can discuss/improve in follow up changes. 🥂
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acpana, yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
google-oss-prow
bot
merged commit 4cfd5b6
into
GoogleCloudPlatform:master
Working towards being able to run samples & fixtures the same way.