Fix golangci-lint issues and delete unused code. #1924
Conversation
| @@ -602,7 +601,7 @@ func (t *ForeignModsTest) ReadBeyondEndOfFile() { | |||
| AssertEq(contents[contentLen-1], buf[0]) | |||
|
|
|||
| if err == nil { | |||
| n, err = f.Read(buf) | |||
| n, _ = f.Read(buf) | |||
There was a problem hiding this comment.
Instead of this should we put Assert(nil, err) ?
There was a problem hiding this comment.
I tried doing that. Seems like these errors have been deliberately ignored. Adding such asserts causes the tests to fail.
| @@ -240,7 +240,7 @@ func (t *AppendObjectCreatorTest) CallsComposeObjectsWithObjectProperties() { | |||
| WillOnce(Return(nil)) | |||
|
|
|||
| // Call | |||
| t.call() | |||
| _, _ = t.call() | |||
There was a problem hiding this comment.
Should we capture err and assert?
There was a problem hiding this comment.
Asserting for error not being nil causes tests to fail.
There was a problem hiding this comment.
No, it isn't
| @@ -332,15 +332,15 @@ const ( | |||
| func (tf *tempFile) ensure(limit int64) error { | |||
| switch tf.state { | |||
| case fileIncomplete: | |||
| size, err := tf.f.Seek(0, 2) | |||
| size, _ := tf.f.Seek(0, 2) | |||
There was a problem hiding this comment.
Should we return err instead of ignoring?
There was a problem hiding this comment.
In certain io methods, an EOF is returned as error. So, an error might not always imply a problem. Therefore I'm a bit scared changing this logic as it might lead to behavior changes. WDYT?
Description
Link to the issue in case of a bug fix.
NA
Testing details