Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BucketType method to locally store bucketType in variable #1896

Merged
merged 12 commits into from
May 20, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented May 9, 2024

Description

Create BucketType() method to returns the type of bucket, allowing the use of a new API specifically designed for HNS buckets.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - Added
  3. Integration tests - Automated

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label May 9, 2024
@Tulsishah Tulsishah marked this pull request as ready for review May 9, 2024 08:24
@Tulsishah Tulsishah requested a review from a team as a code owner May 9, 2024 08:24
@Tulsishah Tulsishah changed the title BucketType method to locally storage bucketType in variable BucketType method to locally store bucketType in variable May 9, 2024
@Tulsishah Tulsishah requested review from raj-prince and removed request for sethiay May 9, 2024 08:25
ankitaluthra1
ankitaluthra1 previously approved these changes May 17, 2024
Copy link
Collaborator

@ankitaluthra1 ankitaluthra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just few nits, please fix those, rest looks good to me

internal/storage/gcs/bucket.go Outdated Show resolved Hide resolved
internal/storage/gcs/bucket.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 13.79310% with 25 lines in your changes are missing coverage. Please review.

Please upload report for BASE (master@4620898). Learn more about missing BASE report.

Files Patch % Lines
internal/storage/mock_bucket.go 0.00% 13 Missing ⚠️
internal/gcsx/prefix_bucket.go 0.00% 2 Missing ⚠️
internal/monitor/bucket.go 0.00% 2 Missing ⚠️
internal/ratelimit/throttled_bucket.go 0.00% 2 Missing ⚠️
internal/storage/caching/fast_stat_bucket.go 0.00% 2 Missing ⚠️
internal/storage/debug_bucket.go 0.00% 2 Missing ⚠️
internal/storage/fake/bucket.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1896   +/-   ##
=========================================
  Coverage          ?   61.35%           
=========================================
  Files             ?      129           
  Lines             ?    12326           
  Branches          ?        0           
=========================================
  Hits              ?     7563           
  Misses            ?     4425           
  Partials          ?      338           
Flag Coverage Δ
unittests 61.35% <13.79%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

raj-prince
raj-prince previously approved these changes May 17, 2024
@Tulsishah Tulsishah merged commit f1d4f7f into master May 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants