Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try adding wp.hooks #234

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Try adding wp.hooks #234

wants to merge 3 commits into from

Conversation

westonruter
Copy link
Collaborator

See #142

@westonruter westonruter mentioned this pull request Jan 28, 2020
Open
@westonruter
Copy link
Collaborator Author

Example usage of this hook: https://gist.github.com/westonruter/ce3b5a568f10f4ca76f8bc5d5e8e4ab3

Experimental implementation of Content Indexing API: https://web.dev/content-indexing-api/

@westonruter
Copy link
Collaborator Author

westonruter commented Jan 28, 2020 •
edited

Tests failing due to /tmp/wordpress/src/wp-includes/js/dist directory not existing, as expected. Will be fixed by updating wp-dev-lib to include this PR: xwp/wp-dev-lib#310. See #235.

@westonruter
Merge branch 'master' of github.com:xwp/pwa-wp into try/wp-hooks
90fcfd5 
* 'master' of github.com:xwp/pwa-wp:
  Update wp-dev-lib to 1.4.0
  Add CHECK_SCOPE=all to bypass Travis diff failure
  Harden workbox-js inclusion and removal of sourceMappingURL comment
  Disable workbox dev logs unless WP_SERVICE_WORKER_DEBUG_LOG constant is true
  Use SCRIPT_DEBUG instead of WP_DEBUG to indicate dev build of Workbox should be used
  Look at PWA_VERSION for dev mode instead of WP_DEBUG
@westonruter westonruter added this to the 0.4 milestone Feb 7, 2020
@westonruter westonruter modified the milestones: 0.4, 0.5 Mar 29, 2020
@westonruter westonruter modified the milestones: 0.5, 0.6 May 14, 2020
@westonruter westonruter changed the base branch from master to develop June 19, 2020 19:07
@westonruter westonruter modified the milestones: 0.6, 0.7 Dec 10, 2020
@westonruter westonruter removed this from the 0.7 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@westonruter