Skip to content
This repository has been archived by the owner on Jul 8, 2020. It is now read-only.

add CircleCI support #67

Closed

Conversation

erezrokah
Copy link

Fixes #16

See pr here erezrokah/gatsby-netlify-cms-aws#10

I'm still missing the github status updates, but I'm assuming it is due to this:
image

(Still waiting for the bot response)

You can test it by installing directly from my branch:

yarn add --dev "https://github.com/erezrokah/lighthousebot#add_circle_ci_support"

Also I think there is a bug in the Travis support. TRAVIS_PULL_REQUEST_SLUG should be TRAVIS_REPO_SLUG (https://docs.travis-ci.com/user/environment-variables/).
I think in case of forks TRAVIS_PULL_REQUEST_SLUG will contain the information of the fork, where you actually want to update the current repo status (I'm not sure since I don't use Travis).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@erezrokah
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@erezrokah erezrokah closed this Jul 8, 2019
@erezrokah erezrokah deleted the add_circle_ci_support branch July 8, 2019 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circle CI support
2 participants