Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrategyHandler.doneWaiting may result in unhandled promise rejections #3171

Closed
joshkel opened this issue Feb 1, 2023 · 1 comment · May be fixed by #3320
Closed

StrategyHandler.doneWaiting may result in unhandled promise rejections #3171

joshkel opened this issue Feb 1, 2023 · 1 comment · May be fixed by #3320

Comments

@joshkel
Copy link
Contributor

joshkel commented Feb 1, 2023

Library Affected:
workbox-strategies

Browser & Platform:
all browsers

Issue or Feature Request Description:

While investigating some unhandled rejection errors in our application, I found that StrategyHandler.doneWaiting throws on the first rejected promise that it encounters. This means that subsequent rejected promises may result in unhandled rejection errors.

joshkel added a commit to joshkel/workbox that referenced this issue Feb 1, 2023
doneWaiting throws on the first rejected promise that it encounters.  This means that subsequent rejected promises may result in unhandled rejection errors.

Fixes GoogleChrome#3171
joshkel added a commit to joshkel/workbox that referenced this issue May 31, 2023
doneWaiting throws on the first rejected promise that it encounters.  This means that subsequent rejected promises may result in unhandled rejection errors.

Fixes GoogleChrome#3171
joshkel added a commit to joshkel/workbox that referenced this issue Oct 30, 2023
doneWaiting throws on the first rejected promise that it encounters.  This means that subsequent rejected promises may result in unhandled rejection errors.

Fixes GoogleChrome#3171
@tomayac
Copy link
Member

tomayac commented Apr 25, 2024

Hi there,

Workbox is moving to a new engineering team within Google. As part of this move, we're declaring a partial bug bankruptcy to allow the new team to start fresh. We realize this isn't optimal, but realistically, this is the only way we see it working. For transparency, here're the criteria we applied:

Thanks, and we hope for your understanding!
The Workbox team

@tomayac tomayac closed this as completed Apr 25, 2024
joshkel added a commit to joshkel/workbox that referenced this issue Apr 27, 2024
doneWaiting throws on the first rejected promise that it encounters.  This means that subsequent rejected promises may result in unhandled rejection errors.

Fixes GoogleChrome#3171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants