Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New sample] Open Chrome API reference page (omnibox, alarms, messaging sample) #848
base: main
Are you sure you want to change the base?
[New sample] Open Chrome API reference page (omnibox, alarms, messaging sample) #848
Changes from 10 commits
d7870b1
d02fb15
e1f7e31
00b7667
b6c435e
ceb4e80
f058253
8b3c991
5f37871
48f8772
6b13a54
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you pick a name that better explains what input is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use async await
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used
.then()
here b/c the return value of theonMessage
listener determines if Chrome expectssendResponse
to be called.If we use async/await, this function will return a Promise, and Chrome will always expect
sendResponse
to be called.We could wrap the call to
.get()
in an async IIFE, but it seems like overkill for this tutorial😊There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know that, have you got a link to where this is explained. Curious to learn how this works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the section that explain this, but I think it can be explained better:
returns boolean | undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! That's not intuitive.
One thing: maybe rename the message field from
greeting
totype
as it better expresses what this field is used for.