Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power/keepawake: Split into basic/advanced and add popup to select which mode, and configurable timeout #1115

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nielm
Copy link

@nielm nielm commented Feb 29, 2024

This PR branches the power 'keepAwake' sample extension into a simple basic extension, and an advanced extension.

The advanced extension adds a popup menu and configurable timeout.

image

There is a context menu option to disable this popup, and revert to the classical behavior where the state is rotatated when the icon is clicked (like the basic version does)

Thre is also a context menu option to explicitly open the popup

image

@nielm nielm force-pushed the main branch 2 times, most recently from 54e7bbe to c697327 Compare March 1, 2024 09:52
@patrickkettner
Copy link
Collaborator

@nielm Thanks for the PR! I look forward to publishing the enhancements. As this is a samples library, would you be open to making this an "advanced" version of the sample? Just have you version be a separate folder, like we have in fontSettings. I plan on publishing your changes to the published version once we merge this in.

api-samples/power/README.md Outdated Show resolved Hide resolved
@nielm nielm changed the title Add popup to select which mode, and configurable timeout Power/keepawake: Split into basic/advanced and add popup to select which mode, and configurable timeout Mar 7, 2024
@nielm
Copy link
Author

nielm commented Mar 7, 2024

@nielm Thanks for the PR! I look forward to publishing the enhancements. As this is a samples library, would you be open to making this an "advanced" version of the sample? Just have you version be a separate folder, like we have in fontSettings. I plan on publishing your changes to the published version once we merge this in.

Done.

There are now 2 subdirectories of api-samples/power: keepAwake Basic which is the original code, and keepAwake Advanced which is the version with the popup and timeouts.

I tried to preserve the history of both, but Git is not so good at doing that!

@jpmedley jpmedley requested a review from oliverdunk March 7, 2024 16:56
@jpmedley
Copy link
Contributor

jpmedley commented Mar 7, 2024

@oliverdunk I'm not sure why I was pegged as the only reviewer for this. LGTM on the README.

@oliverdunk
Copy link
Member

@patrickkettner, would you be comfortable reviewing this given your existing thread?

@oliverdunk oliverdunk requested review from patrickkettner and removed request for oliverdunk March 12, 2024 16:55
@nielm
Copy link
Author

nielm commented Apr 29, 2024

Ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants