Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update DNR samples to work in new DCC #1083

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patrickkettner
Copy link
Collaborator

fixes #1082

Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@hrmtsh2
Copy link

hrmtsh2 commented Mar 18, 2024

Hi, I came here from the discussion on #1082 as I was having the same issue. However this fix also doesn't seem to change things, and somewhere down the line the changes were reverted?
I was trying to run this sample (in relation to my potential work on building an interactive tool to view changes in rules for DNR-bassed extensions for the GSoC program), but it doesn't seem to work.
As mentioned in #1082 by @oliverdunk, I tried to keep both "main_frame", "xmlhttprequest" in the resourceTypes key to accommodate both sites with service workers and with main_frame, but to little avail. The only change I see is that the console message in service_worker.js now shows the message confirming the redirection (I assume the tabId of -1 indicates that it is not tab-specific?).
However, the redirection still doesn't occur. Kindly tell me where I am going wrong.

Edit: I understand that the original user with the issue also didn't see anything get fixed when they tried this fix. However, they did see the desired outcome when they removed the resourceType section altogether. This doesn't seem to happen on my end, however. There is a message, as before, indicating the redirection, but no actual redirection occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manifest V3 declarativeNetRequest redirect sample is completely broken on latest chrome 121
3 participants